clarify top bound and how it feeds into rep range check #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresag01
reviewed
Jan 31, 2025
tariqkurd-repo
commented
Jan 31, 2025
Signed-off-by: Tariq Kurd <[email protected]>
tariqkurd-repo
commented
Jan 31, 2025
Signed-off-by: Tariq Kurd <[email protected]>
|
Yes, nice tidy-ups, and you're right that the overflow should be ignored for the representability check. The tricky thing to get right is the bounds decoding for wrapping cases, but I think that's made clear in the bounds decoding section. Thanks for sorting this. I think this closes #293. Sorry for the delay on that, but I'm glad this has had multiple eyes now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PeterRugg some small clarifications in the top bound and representable range check