Skip to content

Commit

Permalink
Apply suggestions from PR review
Browse files Browse the repository at this point in the history
Signed-off-by: Ravi Sahita <[email protected]>
  • Loading branch information
rsahita authored Sep 30, 2024
1 parent 895183b commit 2af4535
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions chapter3.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,7 @@ every bit position in the `SDID` field, then reading back the value in `mttp`
to see which bit positions in the `SDID` field hold a one. The
least-significant bits of `SDID` are implemented first: that is, if `SDIDLEN` >
0, `SDID`[`SDIDLEN`-1:0] is writable. The maximal value of `SDIDLEN`, termed
`SDIDMAX`, is 6 for `Smmtt[34 | 46 | 56]` and consequently allows for up to
64 supervisor domains.
`SDIDMAX`, is 6 for `Smmtt[34 | 46 | 56]`.

The `mttp` register is considered active for the purposes of the physical
address protection algorithm unless the effective privilege mode is `M`.
Expand Down
8 changes: 4 additions & 4 deletions chapter4.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ RV64 and <<mtt-l1-rv32>> for RV32.
|`2M_PAGES` a|
This encoding applies only to RV64.
_The 32 MiB range of address space is partitioned into 16 2 MiB pages where each
page has read/write/execute/access disallowed/not specified via the `INFO` field._
page has read/write/execute access specified via the `INFO` field._
The `INFO` field holds 16 2-bit `PERM` access-encoding for each 2 MiB address
range to indicate: `no_access_allowed` (00b), `read-execute-allowed` (01b),
`read-write-allowed` (10b), `read-write-execute-allowed` (11b). Bits
Expand All @@ -159,7 +159,7 @@ reserved and must be zero.
|`4M_PAGES` a|
This encoding applies only to RV32.
_The 32 MiB range of address space is partitioned into 8 4 MiB pages where each
page has read/write/execute/access disallowed/not specified via the `INFO` field._
page has read/write/execute access specified via the `INFO` field._
The `INFO` field holds 8 2-bit `PERM` access-encoding for each 4 MiB address
range to indicate: `no_access_allowed` (00b), `read-execute-allowed` (01b),
`read-write-allowed` (10b), `read-write-execute-allowed` (11b). Bits
Expand Down Expand Up @@ -347,8 +347,8 @@ batch optimized via the use of the sequence `SFENCE.W.INVAL`, `MINVAL.SPA` and

[NOTE]
====
Ongoing MTT lookups are not required to complete or terminate when `mttp` is
effectively disabled, unless a `MFENCE.SPA` instruction
MTT lookups that began while `mttp` was active are not required to complete or
terminate when `mttp` is no longer active, unless a `MFENCE.SPA` instruction
matches the `SDID` (and optionally, `PADDR`) is executed. The `MFENCE.SPA`
instruction must be used to ensure that updates to the `MTT` data structures are
observed by subsequent implicit reads to those structures by a hart.
Expand Down

0 comments on commit 2af4535

Please sign in to comment.