-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow different templates for secondary literature #1043
base: develop
Are you sure you want to change the base?
Changes from 1 commit
0fd219f
0cb02f9
c01de1a
2cc3626
d863c01
ba20101
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -246,6 +246,9 @@ de: | |
individual_entry_threatise_printed: "Theoreticum, gedruckt - Teileintrag der Sammlung" | ||
single_threatise_printed: "Theoreticum, gedruckt - Individualeintrag" | ||
|
||
legacy_templates: "LEGACY TEMPLATES" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are trying to not put "placeholders" in the language files, so every new entry should be translated into its appropriate language before being added. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just followed @xhero advice: #1017 (comment) So, which is the preferred way now? |
||
legacy_publication: "SECONDARY LITERATURE UNIFIED TEMPLATE" | ||
|
||
#################### MENUS | ||
menu_home: "Home" | ||
menu_sources: "Quellen" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
display: | ||
legacy_templates: | ||
legacy_publication: | ||
record_type: default_publication | ||
|
||
default_mapping: | ||
legacy_publication: "default" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having these changes in this patch makes it difficult to review this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but Emacs strips those extra spaces for me. In fact, there are so many in Muscat that it is difficult for me to stop Emacs to strip them everywhere else. Shouldn't be a policy in Muscat, like in other projects, to strip them before commiting upstream? I know that there are git hooks for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, I have just seen that from the Github web interface it is possible to hide whitespace changes, using the icon in the middle of the Review changes button line.