Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bumps in model outcome nearby source due to too little precision. #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

monty241
Copy link

Model outcome nearby source can be significantly influenced due too little precision and rounding errors.

Changes by Gerard Cats.

Causes significant bumps of actual calculation outcomes nearby a source.
@monty241 monty241 changed the title 20201115 fix bumpy behaviour due to too little precision. Fix bumps in model outcome nearby source due to too little precision. Nov 15, 2020
@monty241
Copy link
Author

It has been silent around this pull request on a bug since last November. Is there anything I can do in terms of explanation, elaboration or code comments to ensure proper progress of the resolution for this bug?

@RIVM-OPS
Copy link
Collaborator

First of all, we'd like to apologise for the late reaction. We'll try to reply more quickly to future issues and pull requests.

Thank you for this pull request. The development of OPS takes place on an internal RIVM Gitlab server. Therefore, this pull request cannot be merged directly into this repository. However, useful suggestions will be implemented in future OPS versions. In the following months, we will try to process each pull request manually and we will update this pull request once it has been processed.

For future suggestions for code changes, please contact us by creating an issue or via [email protected] before submitting a pull request.

@RIVM-OPS
Copy link
Collaborator

RIVM-OPS commented Mar 1, 2022

Thank you for your suggestion. Could you provide us with an example of the bumps in the model output near the source?

@RIVM-OPS RIVM-OPS added the enhancement New feature or request label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants