Hide directives when their uses are hidden #5163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4882
This adds some hiding of directives when their uses are hidden. It only checks "one level" deep. Directives are hidden if:
directive(...)
configurationsfield(...)
configurations using the directive are visibleargument(...)
configurations using the directive are visiblevalue(...)
configurations using the directive are visibleIt doesn't do recursive checking, so if a type is hidden because fields using it are hidden, then the directive will still be visible. Maybe that's possible but I'm guessing that adding
visible?
implementations to the app is a less complicated solution in that case.