Update C lexer to handle strings with null bytes #5193
Merged
+91
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`StringValueCStr` returns a null-terminated char* for a String but a
Ruby string might contain null bytes and `StringValueCStr` will raise an
`ArgumentError` ("string contains null byte").
This switches to using a `StringValuePtr` to get a (possibly unterminated)
char* combined with `RSTRING_LEN` to get the string's length.
rmosolgo
approved these changes
Dec 18, 2024
|
You can download Ragel directly from here: http://www.colm.net/open-source/ragel/ I think the zip file has instructions for installing 😅 I re-ran it and pushed the changes here, LGTM |
|
🚢 in graphql_c-parser 1.1.2, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringValueCStrreturns a null-terminated char* for a String but a Ruby string might contain null bytes andStringValueCStrwill raise anArgumentError("string contains null byte").This switches to using a
StringValuePtrto get a (possibly unterminated) char* combined withRSTRING_LENto get the string's length.Note: I can't build or test this because I need ragel 7 which I have no idea how to install. But in theory this solution is good? 😅