Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable runtime window system selection on Linux in iDynTree::Visualizer #1223

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

flferretti
Copy link
Contributor

@flferretti flferretti commented Dec 23, 2024

This PR introduces support for Wayland in the iDynTree::Visualizer, allowing it to use Wayland surfaces and fallback to X11 when necessary.

Fixes #1210

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2024

CLA assistant check
All committers have signed the CLA.

@flferretti flferretti force-pushed the wayland_support branch 3 times, most recently from a0924a4 to dc45c8b Compare January 7, 2025 15:54
Co-authored-by: Silvio Traversaro <[email protected]>
@flferretti
Copy link
Contributor Author

As discussed f2f, I made the compilation with Wayland optional as the function glfwGetWaylandWindow may not be defined in Ubuntu < 20.04. It can be optionally activated with -DIDYNTREE_USES_WAYLAND. Ready for review @traversaro. Thanks!

@traversaro
Copy link
Member

If the support is meant to be activated by -DIDYNTREE_USES_WAYLAND, shouldn't we remove the #define IDYNTREE_USES_WAYLAND in the code?

@flferretti
Copy link
Contributor Author

You're right! I'll fix it

@traversaro
Copy link
Member

Thanks! I will handle a bit the CMake to ensure that this will work out of the box for most users.

@traversaro
Copy link
Member

@flferretti can you check my modifications? I also changed the macro name to avoid confusion as in idyntree IDYNTREE_USES_<dep> is tipically used to refer to a dependency that can be enabled and disabled.

@flferretti
Copy link
Contributor Author

@flferretti can you check my modifications? I also changed the macro name to avoid confusion as in idyntree IDYNTREE_USES_<dep> is tipically used to refer to a dependency that can be enabled and disabled.

Thanks a lot @traversaro! I confirm that it works when the option -DIDYNTREE_GLFW_TRY_WAYLAND_FIRST is activated

@traversaro traversaro merged commit a788a3b into robotology:master Jan 10, 2025
9 checks passed
@flferretti flferretti deleted the wayland_support branch January 10, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants