Improved ImageFile.cpp (file is now closed on error)

robotology · Jan 21, 2025 · 916b4e0 · 916b4e0
1 parent 9bcb705
commit 916b4e0
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/libYARP_sig/src/yarp/sig/ImageFile.cpp b/src/libYARP_sig/src/yarp/sig/ImageFile.cpp
@@ -167,19 +167,22 @@ bool ImageReadRGB_PNG(ImageOf<PixelRgb>& img, const char* filename)
     png_structp png = png_create_read_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);
     if (!png)
     {
+        fclose(fp);
         yCError(IMAGEFILE) << "PNG internal error";
         return false;
     }
 
     png_infop info = png_create_info_struct(png);
     if (!info)
     {
+        fclose(fp);
         yCError(IMAGEFILE) << "PNG internal error";
         return false;
     }
 
     if (setjmp(png_jmpbuf(png)))
     {
+        fclose(fp);
         yCError(IMAGEFILE) << "PNG internal error";
         return false;
     }