Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default command for LEDSubsystem #66

Merged
merged 26 commits into from
Apr 2, 2024
Merged

Added default command for LEDSubsystem #66

merged 26 commits into from
Apr 2, 2024

Conversation

Jetblackdragon
Copy link
Contributor

Added command that turns on a blue light when note is in the index and a green light when the note is aligned.

@Jetblackdragon
Added default command for LEDSubsystem
11f967d 
Added command that turns on a blue light when note is in the index and a green light when the note is aligned.
bobtseattle
bobtseattle requested changes Feb 24, 2024
View reviewed changes
Copy link

@bobtseattle bobtseattle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup, and making sure logic / tolerance is what we need it to be?

src/main/java/frc/team2412/robot/subsystems/LauncherSubsystem.java Outdated Show resolved Hide resolved
src/main/java/frc/team2412/robot/commands/LED/LightsCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/team2412/robot/commands/LED/LightsCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/team2412/robot/subsystems/LauncherSubsystem.java Outdated Show resolved Hide resolved
@Jetblackdragon
Logic errors + spotless
6849c9d 
fixed some logic errors and did a spotless run
@Jetblackdragon
merge conflict
050a27f 
merge conflict
@Jetblackdragon
conflicts
53846a7 
conflicts
@Jetblackdragon
Merge branch 'main' into LED-
5cb2f38
@Jetblackdragon
Removed duplicate method
0f74e67 
Had a duplicate at speed method so removed the new one.
bobtseattle
bobtseattle previously approved these changes Feb 24, 2024
View reviewed changes
Copy link

@bobtseattle bobtseattle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can add other color options in a different PR.

@kirbt
Copy link
Contributor

kirbt commented Feb 26, 2024

It might be useful to add an LED color for communicating to the drivers that the robot's intake is off

jamesdooley4
jamesdooley4 requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@jamesdooley4 jamesdooley4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEDs aren't planned to be installed on the robot this week, so it'd be best to hold off on this until after the Glacier Peak competition.

@iamawesomecat
Copy link
Contributor

LEDs aren't planned to be installed on the robot this week, so it'd be best to hold off on this until after the Glacier Peak competition.

Do we want to close it until then?

@TAKBS2412 TAKBS2412 marked this pull request as draft February 29, 2024 19:50
@TAKBS2412
Copy link
Contributor

LEDs aren't planned to be installed on the robot this week, so it'd be best to hold off on this until after the Glacier Peak competition.

Do we want to close it until then?

I've converted it into a draft for now.

@Jetblackdragon
Intake checks and disable
499a412 
Added color to check if intake is on or not and added a end command to disable the leds
@Jetblackdragon
Spotless
91c275d 
Spotless
@Jetblackdragon
Bugs
2a18196 
Fixed bugs
@Jetblackdragon
Merge branch 'main' into LED-
e6ef1f4
@Jetblackdragon
Spotless
18476f5 
spotless
@Jetblackdragon
Changed deleted motors
36082af 
Fixed methods that used outdated motors
@Jetblackdragon
Added parameter for led command
87273fb 
Added parameter for led command
@Jetblackdragon
enabled led subsystem
78e6074 
enabled led subsystem
TAKBS2412
TAKBS2412 previously approved these changes Mar 16, 2024
View reviewed changes
bobtseattle
bobtseattle reviewed Mar 16, 2024
View reviewed changes
Copy link

@bobtseattle bobtseattle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to make sure there is ambiguity between the state of robot and LEDs.

src/main/java/frc/team2412/robot/subsystems/IntakeSubsystem.java Outdated Show resolved Hide resolved
src/main/java/frc/team2412/robot/commands/LED/LightsCommand.java Outdated Show resolved Hide resolved
@Jetblackdragon
Added color violet
771263e 
New violet color to check if feeder sensor sees a note.
@Jetblackdragon Jetblackdragon marked this pull request as ready for review March 19, 2024 00:48
@Jetblackdragon
Changed isIntakeOn
1837d37 
Changed isIntakeOn method to only check for intaking and not also rejecting
@Jetblackdragon
Merge branch 'LED-' of https://github.com/Jetblackdragon/Crescendo2024 …
8f478b1 
…into LED-
@Jetblackdragon
Merge branch 'main' into LED-
9ee6373
bobtseattle
bobtseattle previously approved these changes Mar 19, 2024
View reviewed changes
Copy link

@bobtseattle bobtseattle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - We can deal with back intake during testing. Though, should deal with failing formatting failures.

jamesdooley4
jamesdooley4 requested changes Mar 30, 2024
View reviewed changes
Copy link
Member

@jamesdooley4 jamesdooley4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to re-enable auto

@Jetblackdragon Jetblackdragon merged commit ee0b43d into robototes:main Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdooley4 jamesdooley4 jamesdooley4 approved these changes

@bobtseattle bobtseattle bobtseattle left review comments

@TAKBS2412 TAKBS2412 TAKBS2412 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jetblackdragon @kirbt @iamawesomecat @TAKBS2412 @jamesdooley4 @bobtseattle