Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove flavors #269

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

remove flavors #269

wants to merge 3 commits into from
+479 −564

Conversation

planthaber
Copy link
Member

remove flavor defs

rock-core/package_set#246

@planthaber planthaber mentioned this pull request Nov 12, 2024
Open
chhtz
chhtz reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@chhtz chhtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if it still checks out the master branch for all packages? Some repositories may have another (possibly broken) branch set as default (I had that issue when I removed the flavor from a different package_set a while ago)

source.yml Outdated Show resolved Hide resolved
@planthaber
Copy link
Member Author

No, but I think if something breaks, it is a task of the maintainer to fix it, there are a lot of broken packages in this package_set anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhtz chhtz chhtz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planthaber @chhtz