Support icu provided by Windows #248
Conversation
paperchalice
force-pushed
the
icu-win
branch
6 times, most recently
from
ffc98e2 to
7bb32ed
Compare
meson.build
Outdated
| if enable_runtime == 'auto' | ||
| enable_runtime = 'libicu' | ||
| endif | ||
| elif libicu_dep.found() |
There was a problem hiding this comment.
Should there be an option here to force the use of external icu?
There was a problem hiding this comment.
I'd say yes, since otherwise it sounds unpredictable to assume the resulting build will work. e.g you provide static ICU libraries in your build environment, upgrade your libpsl clone, and suddenly it starts linking to a different DLL shipped with only certain versions of Windows, so application distribution to older Windows systems breaks.
(Why can't Windows just ship actual forreal ICU...)
| @@ -57,6 +58,16 @@ if ['libicu', 'auto'].contains(enable_runtime) | |||
| endif | |||
| endif | |||
|
|
|||
| if ['libicu-win', 'auto'].contains(enable_runtime) | |||
| libicu_win_dep = cc.find_library('icu', required: false) | |||
There was a problem hiding this comment.
Please also skip this for "auto" when the host machine isn't Windows, as it can't be found anyway. Result: configuring on Linux or macOS or BSD with runtime == auto is a bit faster due to running one less check.
Windows provided
icu.libsince Windows 10 Version 1903.