Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linrongbin16/colorbox.nvim #965

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Add linrongbin16/colorbox.nvim #965

merged 7 commits into from
Nov 21, 2023

Conversation

linrongbin16
Copy link
Contributor

@linrongbin16 linrongbin16 commented Nov 21, 2023

Repo URL:

https://github.com/linrongbin16/colorbox.nvim

Checklist:

  • The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
  • The lines end with a .. This is to conform to awesome-list linting and requirements.
  • The title of the pull request is Add/Update/Remove `username/repo` (notice the backticks around `username/repo`) when adding a new plugin.
  • The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
  • The description doesn't contain emojis.
  • Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
  • Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

@tversteeg
Copy link
Collaborator

tversteeg commented Nov 21, 2023

Hi @linrongbin16, thanks for the PR. I see you put a lot of effort into making the description but I think it's a bit too long to fit with the other items. Could you shorten it a bit?

@linrongbin16
Copy link
Contributor Author

Hi @linrongbin16, thanks for the PR. I see you put a lot of effort into making the description but I think it's a bit too long to fit with the other items. Could you shorten it a bit?

Hi @tversteeg, I reduced some descriptions, would you please take a look?

@tversteeg tversteeg merged commit e33bae0 into rockerBOO:main Nov 21, 2023
2 checks passed
@linrongbin16 linrongbin16 deleted the linrongbin16/colorbox.nvim branch November 21, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants