Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't include @rollup/plugin-typescript in the published package.json #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bnussman
Copy link

@bnussman bnussman commented Dec 13, 2024

Description

  • Updates prepublish.js to not include @rollup/plugin-typescript in the published package.json
  • I noticed ``@rollup/plugin-typescriptin my lockfile when I tried updatingreact-vnc` to the latest version
  • I'm pretty sure the package does not depend on @rollup/plugin-typescript but correct me if I'm wrong. I didn't test this fix.

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant