Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ID-184]Consolidate the information, and make it accessible with a single API call #186

Conversation

stefanvit
Copy link
Collaborator

Description

Consolidate the information, and make it accessible with a single API call

**Resolves #184

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is stuff to be handled.

The API should return the following format:

{
    "received_notifications": [
        {
            //the same message structure as in the get messages API. //from messages_recipients
        }
    ],
    "scheduled_notifications_for_me":[
        {
            //the same message structure as in the get messages API. //from gueue_data.
        }
    ],
    "my_account": {
        //the same structure as get user API - //from users.
    }
}

core/app_apis_services.go Outdated Show resolved Hide resolved
core/app_apis_services.go Outdated Show resolved Hide resolved
Stefan Vitanov added 6 commits January 25, 2025 06:30
    Found in: golang.org/x/[email protected]
    Fixed in: golang.org/x/[email protected]
    Example traces found:
Error:       #1: utils/utils.go:68:43: utils.ModifyHTMLContent calls goquery.NewDocumentFromReader, which calls html.Parse
Error:       #2: utils/utils.go:89:27: utils.ModifyHTMLContent calls goquery.Selection.ReplaceWithHtml, which eventually calls html.ParseFragment
@stefanvit stefanvit requested a review from petyos January 25, 2025 19:57
core/model/message.go Show resolved Hide resolved
core/model/user.go Show resolved Hide resolved
core/app_apis_services.go Outdated Show resolved Hide resolved
@stefanvit stefanvit requested a review from petyos January 30, 2025 12:01
core/model/user.go Show resolved Hide resolved
@stefanvit stefanvit requested a review from petyos January 31, 2025 08:57
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanvit stefanvit merged commit 946f644 into develop Feb 3, 2025
2 checks passed
@stefanvit stefanvit deleted the 184-consolidate-the-information-and-make-it-accessible-with-a-single-api-call branch February 3, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate the information, and make it accessible with a single API call
2 participants