-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ID-184]Consolidate the information, and make it accessible with a single API call #186
Merged
stefanvit
merged 21 commits into
develop
from
184-consolidate-the-information-and-make-it-accessible-with-a-single-api-call
Feb 3, 2025
Merged
[ID-184]Consolidate the information, and make it accessible with a single API call #186
stefanvit
merged 21 commits into
develop
from
184-consolidate-the-information-and-make-it-accessible-with-a-single-api-call
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petyos
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is stuff to be handled.
The API should return the following format:
{
"received_notifications": [
{
//the same message structure as in the get messages API. //from messages_recipients
}
],
"scheduled_notifications_for_me":[
{
//the same message structure as in the get messages API. //from gueue_data.
}
],
"my_account": {
//the same structure as get user API - //from users.
}
}
Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Example traces found: Error: #1: utils/utils.go:68:43: utils.ModifyHTMLContent calls goquery.NewDocumentFromReader, which calls html.Parse Error: #2: utils/utils.go:89:27: utils.ModifyHTMLContent calls goquery.Selection.ReplaceWithHtml, which eventually calls html.ParseFragment
petyos
requested changes
Jan 29, 2025
petyos
requested changes
Jan 31, 2025
petyos
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stefanvit
deleted the
184-consolidate-the-information-and-make-it-accessible-with-a-single-api-call
branch
February 3, 2025 07:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidate the information, and make it accessible with a single API call
**Resolves #184
Review Time Estimate
Type of changes
Checklist: