Clean up bash idioms, use modern interpolation style #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfschr
approved these changes
Oct 3, 2023
|
|
||
| # When debugging use bash unofficial strict mode | ||
| # See http://redsymbol.net/articles/unofficial-bash-strict-mode/ | ||
| $DEBUG && set -euo pipefail |
There was a problem hiding this comment.
Should we always set euo pipefail? (i.e. not only when in debug mode?)
| @@ -1,9 +1,25 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
|
Oh, and please also feel free to add a line here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to clean up the bash idioms used in the alias script. It offers some additional help for debugging, it is possible to run this as
DEBUG=true bash ./aliasto get a line by line rendition of what it is trying to do, and if there are any errors.It introduces some comments to the alias script that explain its usage, and links back to the documentation.
I have a mind to also make this shellcheck clean but wanted some feedback about whether PRs are welcome in this project before doing further work.
This script should be robust in the face of adding additional error checking, such as the Bash unofficial strict mode.