Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Separate Get Methods for Subentities #47

Merged
merged 8 commits into from
Nov 26, 2023

Conversation

romandykyi
Copy link
Owner

This pull request introduces separate HTTP GET methods for retrieving enrollments at semesters and students in groups.

Added GET endpoints

  • api/semesters/[semesterId]/students?page=&pageSize=
  • api/groups/[groupId]/students?page=&pageSize=

These additions offer a more granular approach to fetching data, allowing users to paginate through student records associated with a particular semester or group. This improvement prevents the need to retrieve all student data simultaneously when querying group or semester information by ID.

Due to this change, api/semesters/[semesterId] and api/groups/[groupId] will undergo a revision, no longer including associated students information in their responses.

Other changes

  • EnrollmentDate column was added to the StudentGroups table.
  • Fake data generation was adapted to the previous change.

@romandykyi romandykyi merged commit 179335f into master Nov 26, 2023
1 check passed
@romandykyi romandykyi deleted the make-separate-get-methods-for-subentities branch November 26, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant