Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize vector<u8> deserialization in RuntimeObject #3011

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Optimize vector<u8> deserialization in RuntimeObject #3011

merged 3 commits into from
Dec 6, 2024

Conversation

pause125
Copy link
Collaborator

@pause125 pause125 commented Dec 4, 2024 •
edited
Loading

Summary

  1. Optimize vector<u8> deserialization in RuntimeObject
  2. Add a benchmark for large object transferring.

related issue: #2678

Performance

  1. Given the following Move struct with 100000 elements, the deserialization time in RuntimeObject::load descreased from 4861.5us to 13.7us.
  struct VecU8 has key, store {
    values: vector<u8>
  }

  1. benchmark for bench_tx_exec/l2_tx_transfer_large_object:
    image

  2. benchmark for bench_tx_exec/l2_tx_transfer
    image

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal-v2.1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 2:44am
test-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 2:44am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:44am

@pause125 pause125 requested review from steelgeek091 and removed request for wow-sven and geometryolife December 4, 2024 04:51
@jolestar
Copy link
Contributor

jolestar commented Dec 4, 2024 •
edited
Loading

This PR change the third part move crate, cc @steelgeek091

@pause125 pause125 force-pushed the deserialization-vector-u8 branch from 93a8c25 to e106b9b Compare December 4, 2024 14:12
@pause125 pause125 force-pushed the deserialization-vector-u8 branch from c1d6825 to bb7632c Compare December 5, 2024 00:56
@pause125 pause125 force-pushed the deserialization-vector-u8 branch from bb7632c to 7901f51 Compare December 5, 2024 02:40
@jolestar jolestar merged commit e186728 into rooch-network:main Dec 6, 2024
10 checks passed
@pause125 pause125 mentioned this pull request Dec 9, 2024
Merged
steelgeek091 pushed a commit to steelgeek091/rooch that referenced this pull request Dec 22, 2024
@pause125 @steelgeek091
Optimize vector<u8> deserialization in RuntimeObject (rooch-network#3011
e56d489 
)

* optimize vector<u8> deserialization and add benchmark for transferring large object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelgeek091 steelgeek091 steelgeek091 approved these changes

@jolestar jolestar Awaiting requested review from jolestar jolestar is a code owner

@popcnt1 popcnt1 Awaiting requested review from popcnt1 popcnt1 is a code owner

@baichuan3 baichuan3 Awaiting requested review from baichuan3 baichuan3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pause125 @jolestar @steelgeek091