feat: uni v2 like dex #3050
Merged
feat: uni v2 like dex #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
jolestar
reviewed
Dec 17, 2024
apps/rooch_dex/sources/swap.move
Outdated
| amount_y_out: u64 | ||
| } | ||
|
|
||
| struct RoochDexCap has store, key {} |
There was a problem hiding this comment.
可以删掉 store, RoochDexCap 不允许转让
jolestar
approved these changes
Dec 20, 2024
steelgeek091
pushed a commit
to steelgeek091/rooch
that referenced
this pull request
Dec 22, 2024
* feat: uni v2 like dex * [app] remove rooch dex cap store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is based on the implementation of Pancake
Rooch coin accuracy is u256, but for simplicity and not overflow, the routing entry is limited to u64