feat(rooch-da): add rollback for exec cmd #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 18, 2024 22:33
Add `get_tx_order_hash` command to process transaction order and hash data. Introduced `LedgerTxLoader` for loading and verifying ledger transactions, and updated DACommand to integrate the new functionality.
…d rollback Introduce new transaction and ledger handling with rollback and logging features. This includes TxOrderHashBlockGetter for advanced binary search and rollback management, improved logging with shutdown handling, and restructuring for clearer chunk processing and execution.
Increase mpsc channel buffer size to 16384 for performance improvement and resolve edge cases in binary search for finding the last executed transaction. Ensures better handling of empty lists and accurate last executed transaction detection.
Simplifies the `binary_search_by` logic and refines error handling for `tx_order` mismatch. Ensures alignment with expected behavior and improves code readability.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jolestar
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
crates/rooch/src/commands/da/commands/unpack.rs:121
- The variable name _min_chunk_id is ambiguous and unused. Consider removing it or renaming it to something more meaningful if it will be used in the future.
let (chunks, _min_chunk_id, _max_chunk_id) = collect_chunks(self.segment_dir.clone())?;
Co-authored-by: Copilot <[email protected]>
steelgeek091
pushed a commit
to steelgeek091/rooch
that referenced
this pull request
Dec 22, 2024
## Summary 1. add rollback for catching wrong tx execution 2. implement transaction order hash command for dump tx_order:tx_hash:block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary