Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(da): improve struct documentation & naming #3187

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

popcnt1
Copy link
Collaborator

@popcnt1 popcnt1 commented Jan 13, 2025

No description provided.

Renamed `IndexTxCommand` and related module paths to `IndexCommand` for consistency and clarity. Updated usages across the codebase to reflect the new naming.
Introduce short flags for segment-dir and index-path fields for better CLI usability. Also, rename output to index_path to improve clarity and consistency.
Clarified struct purpose by aligning doc comments with existing definitions. This enhances code readability and aligns with Rust's documentation conventions.
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 4:37pm

Copy link

vercel bot commented Jan 13, 2025

@popcnt1 is attempting to deploy a commit to the Rooch Team on Vercel.

A member of the Team first needs to authorize it.

@popcnt1 popcnt1 merged commit 08c28e3 into rooch-network:main Jan 13, 2025
5 of 9 checks passed
@popcnt1 popcnt1 deleted the refactor/da/index branch January 13, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant