🩹 Ask to star fallback #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QWp6t
reviewed
Dec 5, 2024
| $opened = match (PHP_OS_FAMILY) { | ||
| 'Darwin' => shell_exec('open ' . $this->repoUrl . ' 2>/dev/null') !== null, | ||
| 'Linux' => shell_exec('xdg-open ' . $this->repoUrl . ' 2>/dev/null') !== null, | ||
| 'Windows' => shell_exec('start ' . $this->repoUrl . ' 2>nul') !== null, |
There was a problem hiding this comment.
I might be wrong about the behavior of shell_exec(), but afaik the first argument for start is the window title, i.e., start <title> <command>
Suggested change
| 'Windows' => shell_exec('start ' . $this->repoUrl . ' 2>nul') !== null, | |
| 'Windows' => shell_exec('start "" ' . $this->repoUrl . ' 2>nul') !== null, |
If you just run start <url>, it will open a new cmd prompt with the URL as the title of the prompt.
Changing it to start "" <url> opens the URL in my default browser.
Again, I didn't test with shell_exec(), though, since I don't have PHP installed in Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
wp acorn acorn:install, at the last step you're prompted to star this repo. The command could fail in some instances, like when running the command from a Linux VM:This PR adds a fallback to show the URL to this repo if the open command fails: