Tests paths from a subdirectory of the Git repo #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some tests related to the observations in Issue #394.
Currently the behavior of functions like
add()
,rm_file()
, andcommits(path)
change based on the operating system, the current working directory, whether or not the file exists, and the type of file path (relative versus absolute).As an example, when the file exists, the commands
commits(repo, path = "../root.txt")
andcommits(repo, path = "root.txt")
both return the commits that touch the fileroot.txt
in the root of the Git repo. After the file has been removed,commits(repo, path = "../root.txt")
returns an empty list, butcommits(repo, path = "root.txt")
still works.The crux of the problem is that relative paths are interpreted in 2 distinct ways: relative to the current working directory or relative to the root of the Git repository.