Update Code-Style-Language-Versions.rst #4925
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html Signed-off-by: mosfet80 <[email protected]>
fujitatomoya
reviewed
Jan 7, 2025
There was a problem hiding this comment.
CMake versions are different for each platform, we would want to remove the version here and link https://www.ros.org/reps/rep-2000.html#jazzy-jalisco-may-2024-may-2029 instead?
looking at the tables in the link, the oldest cmake version used among the supported ros versions is 3.16.5. this corresponds to the use of ros humble on openembedded |
Signed-off-by: mosfet80 <[email protected]>
sloretz
requested changes
Jan 16, 2025
| @@ -353,7 +353,7 @@ CMake | |||
| Version | |||
| ^^^^^^^ | |||
|
|
|||
| We will target CMake 3.8. | |||
| We will target CMake 3.16.5 | |||
There was a problem hiding this comment.
Suggested change
| We will target CMake 3.16.5 | |
| Read [REP 2000](https://www.ros.org/reps/rep-2000.html) to determine the minimum CMake version you should support. | |
| Currently the minimum version of any supported ROS distro is **3.14.4** (ROS Humble on macOS). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15
https://cmake.org/cmake/help/v3.31/release/3.31.html