add cpp version for urdf_tutorial #4926
Conversation
some command to launch debug demo is wrong and correct it Signed-off-by: Demonmasterlqx <[email protected]>
Signed-off-by: Demonmasterlqx <[email protected]>
…obot-State-Publisher-py.rst change name Signed-off-by: Demonmasterlqx <[email protected]>
add cpp version Signed-off-by: Demonmasterlqx <[email protected]>
add
.. redirect-from::
Tutorials/URDF/Using-URDF-with-Robot-State-Publisher
Signed-off-by: Demonmasterlqx <[email protected]>
There was a problem hiding this comment.
Hi @Demonmasterlqx, thank you so much for your contribution! We really appreciate it.
I sent over a bunch of suggestions. Before I approve this I would like to see more comments in main C++ source file. It really helps users when we document the example code in excruciating detail.
Other than that I think we have to discuss the copyright of the code cited in pull request. I don't think it is a problem, but we need some clarity on how to handle it appropriately.
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
|
|
||
| Fire up your favorite editor and paste the following code into ``urdf_tutorial_cpp/src/urdf_tutorial.cpp`` | ||
|
|
||
| .. code-block:: cpp |
There was a problem hiding this comment.
This section is good but I would really like to see the code commented in excruciating detail. Telling the user what to do is good, but telling them why they should do it is better.
A good rule of thumb is that every time there is a whitespace break you should include a comment.
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst
Show resolved
Hide resolved
| ------- | ||
|
|
||
| You created a ``JointState`` publisher node and coupled it with ``robot_state_publisher`` to simulate a walking robot. | ||
| The code used in these examples is originally from `here <https://github.com/benbongalon/ros2-migration/tree/master/urdf_tutorial>`__. |
There was a problem hiding this comment.
@fujitatomoya how should we handle the copyright on this kind of stuff?
| The code used in these examples is originally from `here <https://github.com/benbongalon/ros2-migration/tree/master/urdf_tutorial>`__. | ||
|
|
||
| Credit is given to the authors of this | ||
| `ROS 1 tutorial <http://wiki.ros.org/urdf/Tutorials/Using%20urdf%20with%20robot_state_publisher>`__ |
There was a problem hiding this comment.
I don't know if we need these lines.
There was a problem hiding this comment.
Actually, I just copy these form python version. So I tend to delete them. QWQ
Signed-off-by: Demonmasterlqx <[email protected]>
Polish my language Signed-off-by: Demonmasterlqx <[email protected]>
add code comment Signed-off-by: Demonmasterlqx <[email protected]>
fix format problems Signed-off-by: Demonmasterlqx <[email protected]>
|
Hi @kscottz ! Thank you so much for helping me to polish my words and give some suggestion. I have add some code comment into code blocks and polish my words |
No description provided.