Hardware Configuration Manager #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For details, see the companion request in the firmware: rosflight/rosflight_firmware#369. |
dpkoch
requested changes
Jan 9, 2020
There was a problem hiding this comment.
Looking good! Thank you!
Just a few minor suggestions so far. However, it looks like your editor has indented everythin inside of the namespace rosflight_io { /* ... */ } in rosflight_io.cpp, which makes the diff impossible to read. Could you push another commit that fixes that?
Also, in config_manager.cpp, if you wrap everything in namespace mavrosflight { /* ... */ } you can get rid of the mavrosflight:: in front of all the function definitions, which would be more consistent with the rest of the code base.
BillThePlatypus
changed the title
|
As a note, this also adds the |
# Conflicts: # rosflight_sim/src/sil_board.cpp
BillThePlatypus
commented
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interfaces with the firmware hardware configuration manager. This adds two new services, config_set and config_get.