Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show button to verify vat ID #260

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

Checklist

@lukicenturi lukicenturi requested a review from a team as a code owner December 9, 2024 14:13
@kelsos
Copy link
Member

kelsos commented Dec 9, 2024

@lukicenturi I did a quick check looks okish to me

What I am not 100% sure is the button to verify in the tooltip, but maybe we can discuss that tomorrow during the call with @AJAyanbisi

Other than that I don't see any problem.

@lukicenturi lukicenturi force-pushed the vat-check branch 2 times, most recently from 2464260 to faabd35 Compare December 11, 2024 12:21
@kelsos kelsos changed the base branch from main to develop December 11, 2024 12:37
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 24dd28d into rotki:develop Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants