Geoloc: fix bad usage of path API that resulted in temporary files no…

…t being created where expected Fixes OSGeo#10671
rouault · Aug 28, 2024 · 47917e4 · 47917e4
1 parent d1efd4e
commit 47917e4
Showing 1 changed file with 21 additions and 9 deletions.
diff --git a/alg/gdalgeoloc_dataset_accessor.h b/alg/gdalgeoloc_dataset_accessor.h
@@ -117,10 +117,14 @@ bool GDALGeoLocDatasetAccessors::AllocateBackMap()
     if (poDriver == nullptr)
         return false;
 
+    // CPLResetExtension / CPLGenerateTempFilename generate short-lived strings,
+    // so store them in a long-lived std::string
+    const std::string osBackmapTmpFilename =
+        CPLResetExtension(CPLGenerateTempFilename(nullptr), "tif");
     m_poBackmapTmpDataset = poDriver->Create(
-        CPLResetExtension(CPLGenerateTempFilename(nullptr), "tif"),
-        m_psTransform->nBackMapWidth, m_psTransform->nBackMapHeight, 2,
-        GDT_Float32, m_aosGTiffCreationOptions.List());
+        osBackmapTmpFilename.c_str(), m_psTransform->nBackMapWidth,
+        m_psTransform->nBackMapHeight, 2, GDT_Float32,
+        m_aosGTiffCreationOptions.List());
     if (m_poBackmapTmpDataset == nullptr)
     {
         return false;
@@ -133,10 +137,14 @@ bool GDALGeoLocDatasetAccessors::AllocateBackMap()
     backMapXAccessor.SetBand(poBandX);
     backMapYAccessor.SetBand(poBandY);
 
+    // CPLResetExtension / CPLGenerateTempFilename generate short-lived strings,
+    // so store them in a long-lived std::string
+    const std::string osBackmapWeightsTmpFilename =
+        CPLResetExtension(CPLGenerateTempFilename(nullptr), "tif");
     m_poBackmapWeightsTmpDataset = poDriver->Create(
-        CPLResetExtension(CPLGenerateTempFilename(nullptr), "tif"),
-        m_psTransform->nBackMapWidth, m_psTransform->nBackMapHeight, 1,
-        GDT_Float32, m_aosGTiffCreationOptions.List());
+        osBackmapWeightsTmpFilename.c_str(), m_psTransform->nBackMapWidth,
+        m_psTransform->nBackMapHeight, 1, GDT_Float32,
+        m_aosGTiffCreationOptions.List());
     if (m_poBackmapWeightsTmpDataset == nullptr)
     {
         return false;
@@ -214,9 +222,13 @@ bool GDALGeoLocDatasetAccessors::LoadGeoloc(bool bIsRegularGrid)
         if (poDriver == nullptr)
             return false;
 
-        m_poGeolocTmpDataset = poDriver->Create(
-            CPLResetExtension(CPLGenerateTempFilename(nullptr), "tif"), nXSize,
-            nYSize, 2, GDT_Float64, m_aosGTiffCreationOptions.List());
+        // CPLResetExtension / CPLGenerateTempFilename generate short-lived
+        // strings, so store them in a long-lived std::string
+        const std::string osGeolocTmpFilename =
+            CPLResetExtension(CPLGenerateTempFilename(nullptr), "tif");
+        m_poGeolocTmpDataset =
+            poDriver->Create(osGeolocTmpFilename.c_str(), nXSize, nYSize, 2,
+                             GDT_Float64, m_aosGTiffCreationOptions.List());
         if (m_poGeolocTmpDataset == nullptr)
         {
             return false;