Initial React migration #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding some ESLint configs for React.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
reviewed
Jan 25, 2024
Co-authored-by: Andy Sweet <[email protected]>
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
reviewed
Jan 25, 2024
andy-sweet
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Looks good to me. There are a few unresolved comments, but those can be resolved with follow-up PRs. I'll let you decide which ones you want to bring into this.
Only ask is to update the PR title and description to reflect the work rather than the work-in-progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, my apologies in advance for the size of this PR. If interested I can break it down into smaller pieces. Certainly the SDS stuff could be moved to a separate PR. In any case consider this WIP/draft.
I'm also happy to have a live session to discuss these changes and what I've learned in the process (so far). Maybe this would be a good time to loop in another dev (Jeremy) for some review.
TODO to reach feature parity with
main: