-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile device accessibility #121
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…Controls to be hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on my iPhone and iPad!
Maybe a suggestion for iPhone, can we add a note somewhere that signifies there are more features on the desktop version?
Another suggestion for iPhone, can we run like a demo of the tracks? Just something that could show something cool or a general overview? That way we can show some tracks even if we don't have space for explicitly selecting them?
Thanks @kyleawayan! I added a pop-up window when opening the viewer on a phone, and will make an issue for the other suggestion |
Looks good! Pretty neat to see this work on mobile even in a limited capacity. Is there a way to disable (gray out) the unavailable selection modes as well? |
Hi @aganders3, yes I tried to disable the first two selection modes (when using a tablet), but this was not possible, to my knowledge. The problem is that |
This PR implements accessibility functionalities for mobile devices. The app detects what kind of device is used (desktop/tablet/phone) and changes the layout and functionalities accordingly.
Implemented:
select cells
button for selection (sinceshift+click
does not workshift+click
would still work if the tablet had a keyboard connectediPad video:
app_iPad_Oct2_v2.MP4
iPhone video:
app_iPhone_Oct1.mp4
(Sorry for the overload of pushes to this PR. The build-in Vercel preview was the easiest way to quickly check the compatibility with iPhone/iPad :) )