Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese update #310

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Japanese update #310

merged 4 commits into from
Dec 17, 2024

Conversation

jeandeaual
Copy link
Contributor

Following-up on #304.

This improves on #213.

The translation for \defaultsensesname can be found on page 10 of the free Japanese Basic Rules:

Screenshot_2021-01-24 dnd_dm_br_ver2 pdf

I fixed the translation for \numberperdayeachname according to the Japanese Monster Manual (see the last line):
2021-01-24-0001 (Small)

Also, I found an issue regarding colons in some translations like \meleeorrangedattackname. The translation includes the Japanese colon (:) but the template already adds a standard colon:

colon

Some other translations like \innateatwillname or \numberperdayname use the standard colon instead of the Japanese one:
colon2

I think this is related to #212, i.e. colons should be moved from the template to all translation files. Since this concerns other translations I wanted some opinion before including it in this PR.

For reference, here is the example PDF compiled in Japanese.

@jeandeaual
Copy link
Contributor Author

Regarding \renewcommand\tocchapterabbreviationname{Ch.}, chapter is usually written as 第1章 (for chapter 1). Can I use \renewcommand\tocchapterabbreviationname{第|1|章}?
For \renewcommand\pageabbreviationname{pg.}, I couldn't find any reference to it in a source book, so I left it as is.

@jeandeaual jeandeaual changed the base branch from master to 0.8 January 26, 2021 00:10
@BrianCriswell
Copy link
Member

BrianCriswell commented Jan 26, 2021

If there is not a |1| in the English file, then it is not available. For situations where this is needed, please add a comment to #308.

"pg." is for referencing a page number for a link. We have the basics of an auto referencing system started with DndArea which gives a page number (pg. XX). This would be used there.

I noticed the build still failed. Is your branch based on the 0.8? Either you need to rebase your branch or fork 0.8 and copy over your changes.

@jeandeaual
Copy link
Contributor Author

jeandeaual commented Jan 26, 2021

If there is not a |1| in the English file, then it is not available. For situations where this is needed, please add a comment to #308.

"pg." is for referencing a page number for a link. We have the basics of an auto referencing system started with DndArea which gives a page number (pg. XX). This would be used there.

Then I think pg. also needs a |1| in Japanese. I'll add that to #308.

I noticed the build still failed. Is your branch based on the 0.8? Either you need to rebase your branch or fork 0.8 and copy over your changes.

Sorry, my 0.8 branch was out of date. I rebased on the latest version from your repository.

Copy link
Member

@BrianCriswell BrianCriswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for sticking with it. Just the one change for "pg." and "Ch.".

lib/languages/japanese.sty Show resolved Hide resolved
@BrianCriswell BrianCriswell changed the base branch from 0.8 to dev December 17, 2024 19:02
@BrianCriswell BrianCriswell merged commit 19b5a07 into rpgtex:dev Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants