-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese update #310
Japanese update #310
Conversation
Regarding |
If there is not a |1| in the English file, then it is not available. For situations where this is needed, please add a comment to #308. "pg." is for referencing a page number for a link. We have the basics of an auto referencing system started with DndArea which gives a page number (pg. XX). This would be used there. I noticed the build still failed. Is your branch based on the |
56e96e1
to
b1f49f1
Compare
Then I think pg. also needs a |1| in Japanese. I'll add that to #308.
Sorry, my 0.8 branch was out of date. I rebased on the latest version from your repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for sticking with it. Just the one change for "pg." and "Ch.".
1edb1d5
to
c44676e
Compare
Following-up on #304.
This improves on #213.
The translation for
\defaultsensesname
can be found on page 10 of the free Japanese Basic Rules:I fixed the translation for
\numberperdayeachname
according to the Japanese Monster Manual (see the last line):Also, I found an issue regarding colons in some translations like
\meleeorrangedattackname
. The translation includes the Japanese colon (:) but the template already adds a standard colon:Some other translations like
\innateatwillname
or\numberperdayname
use the standard colon instead of the Japanese one:I think this is related to #212, i.e. colons should be moved from the template to all translation files. Since this concerns other translations I wanted some opinion before including it in this PR.
For reference, here is the example PDF compiled in Japanese.