automatic: Fix end-of-lines in messages sent by email emitter #1992
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sendmail 8.18.1 started to reject e-mail messages without CRLF line
endings:
# dnf-automatic
libcurl error while sending e-mail: Weird server reply
# journalctl -f
sendmail[7095]: 508DXZbS007095: collect: relay=localhost, from=<root@localhost>, info=Bare linefeed (LF) not allowed, where=body, status=tempfail
This is a deliberate change in Sendmail 8.18.1. And the cause is that
automatic plugin composes a message body with UNIX line endings and
passes it to cURL library with CURLOPT_READDATA option.
While cURL automatically escapes leading dots in the body (".\r\n"),
it does not normalize end-of-lines
<curl/curl#15942>.
This patch fixes it by asking cURL to perform the normalization.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2335508
Merged
via the queue into
rpm-software-management:main
with commit Jan 9, 2025
9a5cba8
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendmail 8.18.1 started to reject e-mail messages without CRLF line endings:
This is a deliberate change in Sendmail 8.18.1. And the cause is that automatic plugin composes a message body with UNIX line endings and passes it to cURL library with CURLOPT_READDATA option.
While cURL automatically escapes leading dots in the body (".\r\n"), it does not normalize end-of-lines
curl/curl#15942.
This patch fixes it by asking cURL to perform the normalization.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2335508