Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io conflicts with builtin #97

Merged
merged 3 commits into from
Feb 4, 2025
Merged

io conflicts with builtin #97

merged 3 commits into from
Feb 4, 2025

Conversation

tjlane
Copy link
Collaborator

@tjlane tjlane commented Feb 4, 2025

Ruff was (rightfully) complaining that meteor.io could parrot the io builtin. So, simply rename meteor/io.py to mtzio.py.

I further cleared a warning regarding outdated ruff rules, and changed one line in test_scale.py that mypy was complaining about. This allows the PR to pass.

@tjlane tjlane self-assigned this Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (8769c2f) to head (fc5720b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files          15       15           
  Lines         938      938           
=======================================
  Hits          897      897           
  Misses         41       41           
Flag Coverage Δ
unittests 95.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kmdalton kmdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be uncontentious and safe to me! Now I feel like I have to rename all the io submodules in all my programs 😮‍💨.

@tjlane tjlane merged commit 9abbbd1 into main Feb 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants