Move logic for new value all into single function rather than two

rstudio · Nov 6, 2023 · 0170372 · 0170372
1 parent 310b145
commit 0170372
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/inst/editor/src/SettingsPanel/SettingsInput/IdInput.tsx b/inst/editor/src/SettingsPanel/SettingsInput/IdInput.tsx
@@ -63,9 +63,9 @@ export function IdInput({
 
   const bindingIds = getAllInputOutputIdsInApp(ui_tree);
 
-  const updateValue = (newValue: string) => {
+  const handleNewValue = (e: React.ChangeEvent<HTMLInputElement>) => {
     // Replace spaces with underscores
-    newValue = newValue.replace(/ /g, "_");
+    const newValue = e.target.value.replace(/ /g, "_");
 
     // Check if the requested new value is already in use and set invalid if it is
     const isTakenId = bindingIds.includes(newValue) && newValue !== value;
@@ -121,9 +121,7 @@ export function IdInput({
           // the way to an empty field getting stuck writing out an id that
           // contains another id as a prefix
           value={isInvalid ? tempValue : value}
-          onChange={(e) => {
-            updateValue(e.target.value);
-          }}
+          onChange={handleNewValue}
           type="text"
         />
         {boundToServer && (