Skip to content

Commit

Permalink
[rom_ctrl,dv] Remove irrelevant coverpoint from rom_ctrl_tlul_cg
Browse files Browse the repository at this point in the history
The check_invalid bin in the coverpoint is not hit, but it doesn't
really matter. The pwrmgr_data_invalid signal means that the
pwrmgr_data_o.good mubi signal that we are generating has an invalid
encoding. This can never happen without an injected fault.

We also don't care about whether this signal is valid or not: it is
not actually read by any code in the IP block, so it doesn’t really
matter if an injected fault causes it to become invalid.

Signed-off-by: Rupert Swarbrick <[email protected]>
  • Loading branch information
rswarbrick committed Aug 14, 2024
1 parent 6d9b5f7 commit 1d6e9a8
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions hw/ip/rom_ctrl/dv/cov/rom_ctrl_cov_if.sv
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ interface rom_ctrl_cov_if (

bit en_full_cov = 1'b1;
bit en_intg_cov = 1'b1;
bit pwrmgr_data_invalid = prim_mubi_pkg::mubi4_test_invalid(pwrmgr_data_o.good);
/////////////////////////////////////
// KMAC APP interface cover points //
/////////////////////////////////////
Expand Down Expand Up @@ -68,12 +67,6 @@ interface rom_ctrl_cov_if (
{1'b1, prim_mubi_pkg::MuBi4True});
}

// Cover the invalid case
cp_rom_invalid_condition: coverpoint pwrmgr_data_invalid {
bins check_invalid = {1};
bins check_valid = {0};
}

// Cover csr requests around the time of check completion
cp_regs_req_check: coverpoint {regs_tl_i.a_valid, pwrmgr_data_o.done} {
bins req_before_done = ({1'b1, prim_mubi_pkg::MuBi4False} =>
Expand Down

0 comments on commit 1d6e9a8

Please sign in to comment.