sbas decode_sbstype6: avoid oob read from iodf[] #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just guarding indexing into iodf[] in decode_sbstype6() rather than limiting sbssat->nsat in decode_sbstype1(). Seems to concur with Annex 10 3.5.4.1 of the Convention on International Civil Aviation "The [PRN] mask shall set up to 51 of the 210 PRN mask values"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No expert in this area, but there appears a possibility of an oob read from iodf[] that might be best guarded against. See also tomojitakasu#747
Just guarding indexing into iodf[] in decode_sbstype6() rather than limiting sbssat->nsat in decode_sbstype1().
Seems to concur with Annex 10 3.5.4.1 of the Convention on International Civil Aviation "The [PRN] mask shall set up to 51 of the 210 PRN mask values"