Skip to content

Commit

Permalink
Simplify internal_investigation
Browse files Browse the repository at this point in the history
RuboCop used to run `internal_investigation` in a matrix as well,
but not anymore since rubocop/rubocop#12964

Drop the matrix to simplify and use the latest stable ruby
  • Loading branch information
Earlopain committed Dec 28, 2024
1 parent a007926 commit b91ca38
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
if: matrix.os != 'windows'
run: (! bundle exec rubocop -h 2> /dev/null) && echo 'RuboCop successfully *not* loaded for local tests'
- name: spec
if: "matrix.coverage != true && matrix.internal_investigation != true"
if: "matrix.coverage != true"
run: bundle exec rake spec

prism:
Expand Down Expand Up @@ -95,7 +95,6 @@ jobs:
os: [ubuntu]
ruby: [2.7]
rubocop: [master]
internal_investigation: [null]
include:
# Instead of testing all possibilities, we test the extreme points of
# a diagonal with the shiniest and latest
Expand All @@ -120,20 +119,13 @@ jobs:
run: cd ../rubocop && bundle exec rake spec

internal_investigation:
name: >-
Coding Style | ${{ matrix.ruby }}
runs-on: ${{ matrix.os }}-latest
strategy:
fail-fast: false
matrix:
os: [ubuntu]
ruby: ["3.0"]
rubocop: [master]
name: Coding Style
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
ruby-version: ruby # Latest stable CRuby version
bundler-cache: true
- name: internal investigation
run: bundle exec rake generate internal_investigation

0 comments on commit b91ca38

Please sign in to comment.