Make RuboCop::AST::IfNode support then?
#341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_rubocop_ast_if_node_support_then_predicate
branch
2 times, most recently
from
e6cf594 to
6c671d4
Compare
marcandre
reviewed
Dec 13, 2024
lib/rubocop/ast/node/if_node.rb
Outdated
| # | ||
| # @return [Boolean] whether the node has an `then` clause | ||
| def then? | ||
| loc.begin&.is?('then') |
There was a problem hiding this comment.
Could you please rebase and use the new loc_is? here? 🙏
This PR makes `RuboCop::AST::IfNode` support `then?`, similar to `RuboCop::AST::InPatternNode` and `RuboCop::AST::WhenNode`.
koic
force-pushed
the
make_rubocop_ast_if_node_support_then_predicate
branch
from
6c671d4 to
a2f86f9
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
RuboCop::AST::IfNodesupportthen?, similar toRuboCop::AST::InPatternNodeandRuboCop::AST::WhenNode.