Clean up CI a bit #353
Merged
Clean up CI a bit #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses a dedicated action which makes it easier to grep
In rubocop/rubocop@43105b4 I found that not setting this is slightly faster for CI Doesn't matter much here but it's less clutter
No need to call this yourself
Makes it more pleasant to read
RuboCop used to run `internal_investigation` in a matrix as well, but not anymore since rubocop/rubocop#12964 Drop the matrix to simplify and use the latest stable ruby
It was part of RuboCop for `internal_investigation`, where it is needed. But here, `internal_investigation` already was its own job step
Earlopain
force-pushed
the
ci-facelift
branch
from
fcdd861 to
42c9ccb
Compare
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if I got this right on the first try 🙃 (I didn't)
A few months ago I and @\bquorning made some tweaks to rubocops CI. This imports some of that work, and does a bit specific to this repo.
I made a handful of individual commits explaining why I did something for each. Overall the workflow files lost a bit of weight and are easier to follow.