Ruby 3.5 compatibility #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padde
force-pushed
the
ruby-3-5-compatibility
branch
from
6102b22 to
3a0b6d6
Compare
Generated by 🚫 Danger |
padde
force-pushed
the
ruby-3-5-compatibility
branch
from
3a0b6d6 to
b54982f
Compare
|
Want to rebase this one? |
This gem was historically included in the default gemset. Starting with
Ruby 3.3.5 though, requiring `ostruct` without explicitly adding it as
dependency generates the following warning:
warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
padde
force-pushed
the
ruby-3-5-compatibility
branch
from
b54982f to
abc1512
Compare
|
@dblock done, please review. |
|
Good work @padde! Interested in helping out with maintaining this library, maybe make the next release? If yes drop me an email to dblock at dblock dot org with your rubygems username. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
The
ostructgem was historically included in the default gems included with Ruby. Starting with Ruby 3.3.5 though, requiringostructwithout explicitly adding it as dependency generates the following warning:As of Ruby 3.5, the
ostructgem will then no longer be shipped with Ruby so we need to explicitly add it to the dependencies.Blockers
Fixes CI
Updates CI matrix so it will be easier to add Ruby 3.3
Bumps grape-swagger to 2.1.1 so it runs with the latest grape release again
TODO