Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fail spec for #705 #707

Conversation

darren987469
Copy link
Contributor

Add a fail spec for #705

Failures:

  1) desc is_array option in hash style
     Failure/Error: is_array true

     NoMethodError:
       undefined method `is_array' for #<#<Class:0x00007fc42dd0c660>:0x00007fc42dd07980>
       Did you mean?  is_a?
     # ./spec/issues/705_is_array_not_supported_in_desc_block_spec.rb:20:in `block (5 levels) in <top (required)>'
    ...

@coveralls
Copy link

coveralls commented Sep 14, 2018

Coverage Status

Coverage remained the same at 99.204% when pulling 506079e on darren987469:fix_is_array_option_in_desc_block into cdc2087 on ruby-grape:master.

@ysv
Copy link

ysv commented Sep 15, 2018

@darren987469 notice that also it overrides hash options in block which looks strange for me too
https://github.com/ruby-grape/grape-swagger/pull/706/files#diff-e2856c84b5197a90f6d3298a589c09d8R14

@darren987469 darren987469 force-pushed the fix_is_array_option_in_desc_block branch from 7a1bd79 to 12584b0 Compare September 17, 2018 01:01
@darren987469 darren987469 force-pushed the fix_is_array_option_in_desc_block branch from 12584b0 to 506079e Compare September 17, 2018 01:16
@grape-bot
Copy link

grape-bot commented Sep 17, 2018

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#707](https://github.com/ruby-grape/grape-swagger/pull/707): Add a fail spec for #705 - [@darren987469](https://github.com/darren987469).

Generated by 🚫 danger

@darren987469
Copy link
Contributor Author

@LeFnord is_array is supported in the latest grape. Test failed in the older version of grape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants