Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Ruby 3.0 support #916

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

godfat
Copy link
Contributor

@godfat godfat commented Jan 2, 2024

All tests passed locally. See #915

@godfat godfat mentioned this pull request Jan 2, 2024
@LeFnord
Copy link
Member

LeFnord commented Jan 2, 2024

does it make sense to also readd it to CI matrix, or are you fine with that?

@LeFnord
Copy link
Member

LeFnord commented Jan 2, 2024

@godfat ^^^

@godfat
Copy link
Contributor Author

godfat commented Jan 2, 2024

@LeFnord Good question. Thanks for asking. It'll be the best to add it to CI matrix as well. However, I see adding it can increase a lot of cost to CI because there's some combinations of versions. If this is acceptable, that would be great. If it's not, then I think it's fine to support it without actually running CI, especially given that it's not being run for some time and it's still passing?

What do you think?

@LeFnord
Copy link
Member

LeFnord commented Jan 2, 2024

mmh … think I'll mörge it, and adapt the CI matrix afterwards, also make a release

@godfat
Copy link
Contributor Author

godfat commented Jan 2, 2024

I amended the commit and added 3.0 support to CI as well. It's very fast. Maybe the cost is fine :)

@godfat
Copy link
Contributor Author

godfat commented Jan 2, 2024

Awesome, thank you so much! A new release will be great, then we can upgrade very quickly.

@LeFnord LeFnord merged commit 46dc3f8 into ruby-grape:master Jan 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants