Update TravisCI build #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvz Does it make sense to rebase this? Does it still work? |
|
I don't think much has changed but I'll give it a shot. |
|
It looks like there's a problem with pry and pry-byebug versions. |
|
Yeah. On ruby 2.3, Possible solutions:
|
|
It looks like the maintainers of this gem want to still target 2.3 (see #412), so I'll go with the first option. |
This does two things: - Move complex dependency logic out of the gemspec. The gemspec logic is only evaluated at build time, so keeping Ruby version dependendent logic in there causes different gems to be published depending on the source machine. - Load slightly older pry versions on Ruby 2.3 and lower, so they work with the pry-byebug version that supports those older Ruby versions.
Taken from 8e7c96a by Garret Thornburg <[email protected]>
|
@mvz The matrix:
include:
- rvm: rbx-2
dist: trusty |
|
Closing this since this project no longer uses TravisCI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on newer protobuf versions while not allowing failures.
Follow-up for #406, which made the build for protobuf 3.0.0 green.