Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop :nodoc: options from core classes that contains methods with docs #322

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Nov 27, 2024

I found some methods are not included in RDoc output, and the :nodoc: option should be the reason.

It seems like there is no reason to opt-out the methods. 7b79bec added the option, but still not clear why we needed it.

@soutaro
Copy link
Member Author

soutaro commented Nov 27, 2024

Oops I should have read this ticket. But still believe having the docs is better. https://bugs.ruby-lang.org/issues/6880

@soutaro soutaro changed the title Drop :nodoc: options from that contains methods with docs Drop :nodoc: options from core classes that contains methods with docs Nov 27, 2024
@kou kou merged commit bc11345 into master Nov 27, 2024
92 checks passed
@kou kou deleted the drop-nodoc branch November 27, 2024 05:15
@kou
Copy link
Member

kou commented Nov 27, 2024

Thanks.

I don't have a strong opinion for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants