Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check variable duplication #2241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check variable duplication #2241

wants to merge 1 commit into from

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Jan 16, 2025

  • Instance variable: Only same type name
  • Class instance variable: Only same type name
  • Class variable: Including inheritance

@ksss
Check variable duplication
795eb65 
* Instance variable: Only same type name
* Class instance variable: Only same type name
* Class variable: Including inheritance
ksss
ksss commented Jan 16, 2025
View reviewed changes
lib/rbs/errors.rb
end
end

class ClassVariableDuplicationError < VariableDuplicationError
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respect https://github.com/soutaro/steep/blob/5f40fc1c599476cf31259c6402746e9b31d14727/lib/steep/diagnostic/signature.rb#L276

@soutaro soutaro added this to the RBS 3.9 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.9
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro