adds Module#const_source_location specs #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moofkit
force-pushed
the
const_source_location
branch
from
5e0b9d1 to
3bc89e7
Compare
moofkit
changed the title
moofkit
force-pushed
the
const_source_location
branch
from
a85d7a2 to
e59722f
Compare
eregon
reviewed
Nov 7, 2020
| describe "with dynamically assigned constants" do | ||
| it "searches a path in the immediate class or module first" do | ||
| ConstantSpecs::ClassA::CS_CONST301 = :const301_1 | ||
| ConstantSpecs::ClassA.const_source_location(:CS_CONST301).should == [__FILE__, 14] |
There was a problem hiding this comment.
Could you use something like __LINE__ - 1 to avoid hardcoding line numbers?
|
|
||
| describe "with statically assigned constants" do | ||
| it "searches location path the immediate class or module first" do | ||
| ConstantSpecs::ClassA.const_source_location(:CS_CONST10).should == [@constants_fixture_path, 78] |
There was a problem hiding this comment.
For these cases, it would be better to define some constants in that file like CS_CONST10_LINE = __LINE__ - 1.
|
@eregon thanks for review! Your ideas is very reasonable and brilliant! I will implement it as soon as possible |
moofkit
force-pushed
the
const_source_location
branch
from
b129b5b to
9af4b34
Compare
|
done! 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #745
Hello, I'm not sure about how detailed this specs should be.
I've just take examples from https://github.com/ruby/spec/blob/master/core/module/const_get_spec.rb
Is it right? Or better to write different examples?
Also add some special cases from docs https://ruby-doc.org/core-2.7.0/Module.html#method-i-const_source_location