Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ui only documentation #385

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Remove ui only documentation #385

merged 3 commits into from
Dec 30, 2024

Conversation

duckinator
Copy link
Member

Replaces #311. Rebased off main so it can be merged.

Here's @kevinlinxc's original description from #311:

Since the removal of ui only was merged (rubygems/rubygems.org#3084), the guides should be updated.

I remove other mentions of it and only talk about it in the place where dropdown is mentioned, explaining that it will still show up for people that have it as their set MFA level. Perhaps this bit is unnecessary but it feels like harmless transparency.

Another idea that I think we should do is link the ui only removal blog post.

@duckinator
Copy link
Member Author

duckinator commented Dec 30, 2024

I split this off of #311 because I don't have access to the upstream repository.

The changes were good, they just needed to be rebased.

The error is a CI configuration problem, and is addressed by #386. The error was fixed by merging #386.

@duckinator duckinator merged commit 648d58c into main Dec 30, 2024
1 check passed
@duckinator duckinator deleted the ui-only-removed branch December 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants