ci: refactor rootfs build automation #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
refactor-dockerfile-ci
branch
5 times, most recently
from
550d0e9 to
4bf0a77
Compare
1 task
austinvazquez
force-pushed
the
refactor-dockerfile-ci
branch
from
4bf0a77 to
3b677f4
Compare
|
Split cosign update automation into #478 |
austinvazquez
force-pushed
the
refactor-dockerfile-ci
branch
2 times, most recently
from
052882b to
12e5aab
Compare
austinvazquez
force-pushed
the
refactor-dockerfile-ci
branch
from
12e5aab to
befb95e
Compare
pendo324
approved these changes
Dec 30, 2024
This change refactors the rootfs build automation to split the workflow into smaller logical jobs. This enables the build job to run on changes to Dockerfile changes. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
refactor-dockerfile-ci
branch
from
befb95e to
772d7bb
Compare
|
Rebased for create-pull-request action update. |
swagatbora90
approved these changes
Dec 30, 2024
|
Going to pull this in. Thanks for taking a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The existing workflow doesn't allow for running image build CI on pull request for changes to Dockerfile.
Description of changes:
This change refactors Finch on Windows rootfs CI to split the workflow into smaller logical jobs for build and push image. This enables build verification of rootfs during pull request for changes to the Dockerfile.
Testing done:
Tested workflow in fork.
ci: refactor rootfs build automation austinvazquez/finch-core#4
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.