Implement nom traits for slices other than byte slices #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some input streams, it doesn't make sense to ignore case when comparing. Make `CompareIgnoreCase` a separate trait to avoid having to implement it anyway.
This can be useful in cases where you already have an in-memory flat representation, but want to use Nom to traverse it in a custom order. This has a few opinionated decisions: - `InputIter` is only implemented when `T: Copy`. This could easily be relaxed to `T: Clone`, but that could be surprising if T is expensive to clone. - `Compare` is only implemented when `T: Eq`. This could be relaxed to PartialEq.
jyn514
force-pushed
the
blanket-impls
branch
from
69b530e to
0d751a2
Compare
epage
added a commit
to epage/winnow
that referenced
this pull request
Feb 1, 2023
This does not help with `Compare` (because of ignore case) and `FindSlice` (`memchr`). Inspired by rust-bakery/nom#1482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful in cases where you already have an in-memory flat representation,
but want to use Nom to traverse it in a custom order. See adamchalmers/aoc21@a8fd28a for a real-world example (in that particular case, the in-memory representation is effectively generated by a lexer, then the tokens are parsed using nom).
This has a few opinionated decisions:
InputIteris only implemented whenT: Copy. This could easily be relaxed toT: Clone,but that could be surprising if T is expensive to clone.
Compareis only implemented whenT: Eq. This could be relaxed to PartialEq.