Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing tuple in code example #1728

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Fix missing tuple in code example #1728

merged 2 commits into from
Apr 21, 2024

Conversation

JonathanPlasse
Copy link
Contributor

Hi,
Just started using nom and I am loving it!
Thank you for your awesome work!

I think tuple is missing in the code example.

@JonathanPlasse JonathanPlasse requested a review from Geal as a code owner February 11, 2024 15:39
doc/choosing_a_combinator.md Outdated Show resolved Hide resolved
@Geal Geal merged commit a209ff1 into rust-bakery:main Apr 21, 2024
14 checks passed
@Geal
Copy link
Collaborator

Geal commented Apr 21, 2024

thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8774141498

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 62.342%

Files with Coverage Reduction New Missed Lines %
src/lib.rs 1 66.67%
src/error.rs 4 16.41%
Totals Coverage Status
Change from base Build 6790049741: 0.1%
Covered Lines: 1826
Relevant Lines: 2929

💛 - Coveralls

@JonathanPlasse JonathanPlasse deleted the patch-1 branch April 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants