Add missing tests for number parsing #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Jul 18, 2024
epage
added a commit
to epage/winnow
that referenced
this pull request
Jul 18, 2024
Pulled from rust-bakery/nom#1769 I skipped the float ones because I didn't feel like adapting them to the `binary` mod.
CodSpeed Performance ReportMerging #1769 will improve performances by 13.57%Comparing Summary
Benchmarks breakdown
|
Geal
approved these changes
Dec 8, 2024
|
Thank you! New tests always help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your time & patience to review this PR.
We are researchers focusing on Rust unit tests, we revised our tool for better readability. By examine the existing code, we found several unit tests can be added to improve the repo's overall unit test coverage(this project is already been well tested).
Thanks again for your time.